Skip to content

update fms2_io docs#1840

Merged
vithikashah001 merged 12 commits intoNOAA-GFDL:mainfrom
rem1776:fms2-io-docs
Mar 31, 2026
Merged

update fms2_io docs#1840
vithikashah001 merged 12 commits intoNOAA-GFDL:mainfrom
rem1776:fms2-io-docs

Conversation

@rem1776
Copy link
Copy Markdown
Contributor

@rem1776 rem1776 commented Feb 12, 2026

Description
updates for fms2_io docs (WIP)

Fixes # (issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 marked this pull request as ready for review February 27, 2026 22:01
@rem1776 rem1776 changed the title update fms2_io module description update fms2_io docs Feb 27, 2026
Copy link
Copy Markdown
Contributor

@mlee03 mlee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's talk later today :)

@mlee03
Copy link
Copy Markdown
Contributor

mlee03 commented Mar 9, 2026

@rem1776 is this ready for re-review?

@rem1776
Copy link
Copy Markdown
Contributor Author

rem1776 commented Mar 9, 2026

@mlee03 Yeah this should be ready

Copy link
Copy Markdown
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment + I tried to explain how the mask work ...

Copy link
Copy Markdown
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but looks very good otherwise :)

@vithikashah001 vithikashah001 merged commit df64d67 into NOAA-GFDL:main Mar 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants